tfsdk: (Plan).SetAttribute() and (State).SetAttribute() Reflection Missing Attribute Path

[bflad]

Module version

Pre v0.3.0 with validation support

Relevant framework source code

// tfsdk/plan.go
func (p *Plan) SetAttribute(ctx context.Context, path *tftypes.AttributePath, val interface{}) []*tfprotov6.Diagnostic {
  // ...
  newVal, newValDiags := reflect.OutOf(ctx, attrType, val)
  // ...
}

// tfsdk/state.go
func (s *State) SetAttribute(ctx context.Context, path *tftypes.AttributePath, val interface{}) []*tfprotov6.Diagnostic {
  // ...
  newVal, newValDiags := reflect.OutOf(ctx, attrType, val)
  // ...
}

// internal/reflect/outof.go
func OutOf(ctx context.Context, typ attr.Type, val interface{}) (attr.Value, []*tfprotov6.Diagnostic) {
	return FromValue(ctx, typ, val, tftypes.NewAttributePath())
}

Expected Behavior

Attribute path information is correctly set during SetAttribute() reflection.

Actual Behavior

Attribute path information is missing.

It seems like reflect.OutOf() should accept *tftypes.AttributePath as a parameter since the only implementations are:

• (Plan).Set()
• (Plan).SetAttribute()
• (State).Set()
• (State).SetAttribute()

References

Found while implementing #127 and seeing unexpected test results:

--- FAIL: TestStateSetAttribute (0.00s)
    --- FAIL: TestStateSetAttribute/AttrTypeWithValidateWarning (0.00s)
        state_test.go:1588: unexpected diagnostics (+wanted, -got):   []*tfprotov6.Diagnostic{
                &{
                        Severity:  s"WARNING",
                        Summary:   "Warning Diagnostic",
                        Detail:    "This is a warning.",
            -           Attribute: s"",
            +           Attribute: s`AttributeName("name")`,
                },
                &{Severity: s"WARNING", Summary: "Warning Diagnostic", Detail: "This is a warning.", Attribute: s`AttributeName("name")`},
              }

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.