Skip to content

Resource Identity: Initial implementation + Schemas #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 18, 2025

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Mar 6, 2025

Since Framework has so many files to update, I felt like this was a good breaking point for a first PR.

This PR implements the tfprotov{5/6}.ProviderServerWithResourceIdentity interface, for each RPC:

  • GetResourceIdentitySchemas: This PR contains about 95% of the implementation with the external packages/internal attribute updates and tests. The missing piece is validation on list attribute (see below).
  • UpgradeResourceIdentity: This RPC will be implemented in a separate PR
  • All of the RPCs that are just adding the identity data to the request/response will be implemented in a separate PR, but they are all additional data, so ignoring them is fine for existing providers.

Other related work for resource identity (coming soon)

  • Adding identity data to request/response of all existing RPCs
  • Validation logic for list attributes
  • Import Resource RPC updates
  • Upgrade Resource Identity implementation
  • Changelogs
  • Website documentation (separate repo)

@austinvalle austinvalle added the enhancement New feature or request label Mar 6, 2025
@austinvalle austinvalle added this to the v1.15.0 milestone Mar 6, 2025
@austinvalle austinvalle marked this pull request as ready for review March 14, 2025 12:48
@austinvalle austinvalle requested a review from a team as a code owner March 14, 2025 12:48
ansgarm
ansgarm previously approved these changes Mar 17, 2025
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏 This is a lot of gruntwork, respect for going through it so meticulously!
I tried my best to find copy paste errors but you let me down here 😆💯

SBGoods
SBGoods previously approved these changes Mar 17, 2025
@austinvalle austinvalle dismissed stale reviews from SBGoods and ansgarm via 62dc4ec March 18, 2025 19:53
@austinvalle austinvalle merged commit 8852480 into main Mar 18, 2025
33 checks passed
@austinvalle austinvalle deleted the feat/resource-identity branch March 18, 2025 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants