Skip to content

internal: Implement fwserver ReadResource testing and update proto6server testing #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2022
Merged

internal: Implement fwserver ReadResource testing and update proto6server testing #360

merged 2 commits into from
Jun 6, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 2, 2022

Reference: #215

@bflad bflad added the tech-debt Issues tracking technical debt that we're carrying. label Jun 2, 2022
@bflad bflad added this to the v0.9.0 milestone Jun 2, 2022
@bflad bflad requested a review from a team as a code owner June 2, 2022 17:43
bendbennett
bendbennett approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 7b5f42d into main Jun 6, 2022
@bflad bflad deleted the bflad-readresource-testing branch June 6, 2022 13:07
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @bendbennett