Skip to content

internal: Replace tfsdk.Schema, tfsdk.Attribute, and tfsdk.Block usage in unit testing #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 13, 2022

Reference: #132

Precursor for fully removing tfsdk package Schema, Attribute, and Block types. Replaced with internal/testing/testschema, datasource/schema, provider/metaschema, provider/schema, and resource/schema equivalents. Removed extraneous unit testing such as datasource versioning, provider Computed, etc. since it will be no longer possible to declare invalid schemas based on the concept.

…e in unit testing

Reference: #132

Precursor for fully removing `tfsdk` package `Schema`, `Attribute`, and `Block` types. Replaced with `internal/testing/testschema`, `datasource/schema`, `provider/metaschema`, `provider/schema`, and `resource/schema` equivalents. Removed extraneous unit testing such as datasource versioning, provider Computed, etc. since it will be no longer possible to declare invalid schemas based on the concept.
@bflad bflad added the tech-debt Issues tracking technical debt that we're carrying. label Dec 13, 2022
@bflad bflad added this to the v1.0.0 milestone Dec 13, 2022
@bflad bflad requested a review from a team as a code owner December 13, 2022 04:11
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 085f2f9 into main Dec 13, 2022
@bflad bflad deleted the bflad/tfsdk-Schema-removals branch December 13, 2022 14:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants