build(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.28.0 to 2.29.0 #183
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.28.0 to 2.29.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.28.0...v2.29.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
| @@ -57,6 +58,10 @@ type ProviderServer struct { | |||
| Provider provider.Provider | |||
| } | |||
|
|
|||
| func (s ProviderServer) GetMetadata(ctx context.Context, request *tfprotov6.GetMetadataRequest) (*tfprotov6.GetMetadataResponse, error) { | |||
| return &tfprotov6.GetMetadataResponse{}, nil | |||
There was a problem hiding this comment.
Since its relatively straightforward, I'd recommend to go ahead an implement the response correctly similar to the GetProviderSchema logic:
resp := &tfprotov6.GetMetadataResponse{
ServerCapabilities: &tfprotov6.ServerCapabilities{
GetProviderSchemaOptional: true,
PlanDestroy: true,
},
}
for typeName := range s.Provider.DataSourcesMap() {
resp.DataSources = append(resp.DataSources, tfprotov6.DataSourceMetadata{
TypeName: typeName,
}),
}
for typeName := range s.Provider.ResourcesMap() {
resp.Resources = append(resp.Resources, tfprotov6.ResourceMetadata{
TypeName: typeName,
}),
}
return resp, nil
There was a problem hiding this comment.
Thanks for the feedback. Have added your suggested changes.
|
Adding this comment for cross-referencing, but explicitly not telling GitHub to close immediately on pull request merge since we probably should release soon afterwards: #185 |
bendbennett
deleted the
dependabot/go_modules/github.com/hashicorp/terraform-plugin-sdk/v2-2.29.0
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Bumps github.com/hashicorp/terraform-plugin-sdk/v2 from 2.28.0 to 2.29.0.
Release notes
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's releases.
Changelog
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's changelog.
Commits
6b58e7fUpdate changelogd419eaahelper/schema: Update to protocol version 5.4 and enable `GetProviderSchemaOp...80fb516all: Update Go Module to Go 1.20 (#1246)027d6b6build(deps): Bump golang.org/x/crypto from 0.12.0 to 0.13.0 (#1244)87f3cd8Result of tsccr-helper -log-level=info -pin-all-workflows . (#1243)c472804build(deps): Bump github.com/hashicorp/hcl/v2 from 2.17.0 to 2.18.0 (#1239)1736372build(deps): Bump github.com/hashicorp/terraform-exec (#1242)82fee9dbuild(deps): Bump github.com/hashicorp/hc-install from 0.5.2 to 0.6.0 (#1241)3e10d01website: Add data consistency error docs for "planned value does not match co...1fe17a7Update CHANGELOG for #1155 (#1238)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)