-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[New Resource] - AWS Prometheus workspace configuration #42478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPWorkspaceConfiguration_' PKG=amp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/amp/... -v -count 1 -parallel 20 -run=TestAccAMPWorkspaceConfiguration_ -timeout 360m -vet=off
2025/05/31 17:18:37 Initializing Terraform AWS Provider...
=== RUN TestAccAMPWorkspaceConfiguration_basic
=== PAUSE TestAccAMPWorkspaceConfiguration_basic
=== RUN TestAccAMPWorkspaceConfiguration_defaultBucket
=== PAUSE TestAccAMPWorkspaceConfiguration_defaultBucket
=== RUN TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== PAUSE TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT TestAccAMPWorkspaceConfiguration_basic
=== CONT TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT TestAccAMPWorkspaceConfiguration_defaultBucket
--- PASS: TestAccAMPWorkspaceConfiguration_defaultBucket (90.82s)
--- PASS: TestAccAMPWorkspaceConfiguration_limitPerLabelSet (97.07s)
--- PASS: TestAccAMPWorkspaceConfiguration_basic (168.72s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 173.909s
This PR introduces a new resource for the AMP workspace configuration options including limits by label set and retention period
Output from Acceptance Testing