Skip to content

[New Resource] - AWS Prometheus workspace configuration #42478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

bonclay7
Copy link
Contributor

@bonclay7 bonclay7 commented May 5, 2025

This PR introduces a new resource for the AMP workspace configuration options including limits by label set and retention period

Output from Acceptance Testing

make build && make testacc TESTARGS='-run=TestAccAMPWorkspaceConfiguration' PKG=amp ACCTEST_PARALLELISM=5
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Building provider...
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/amp/... -v -count 1 -parallel 5  -run=TestAccAMPWorkspaceConfiguration -timeout 360m -vet=off
2025/05/06 17:56:48 Initializing Terraform AWS Provider...
=== RUN   TestAccAMPWorkspaceConfiguration_basic
=== PAUSE TestAccAMPWorkspaceConfiguration_basic
=== RUN   TestAccAMPWorkspaceConfiguration_defaultBucket
=== PAUSE TestAccAMPWorkspaceConfiguration_defaultBucket
=== RUN   TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== PAUSE TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT  TestAccAMPWorkspaceConfiguration_basic
=== CONT  TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT  TestAccAMPWorkspaceConfiguration_defaultBucket
--- PASS: TestAccAMPWorkspaceConfiguration_limitPerLabelSet (80.47s)
--- PASS: TestAccAMPWorkspaceConfiguration_defaultBucket (90.73s)
--- PASS: TestAccAMPWorkspaceConfiguration_basic (153.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	155.508s
...

@bonclay7 bonclay7 requested a review from a team as a code owner May 5, 2025 08:44
Copy link

github-actions bot commented May 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 5, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/amp Issues and PRs that pertain to the amp service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels May 5, 2025
@bonclay7 bonclay7 changed the title draft: [New Resource] - AWS Prometheus workspace configuration [New Resource] - AWS Prometheus workspace configuration May 5, 2025
@bonclay7 bonclay7 marked this pull request as draft May 5, 2025 08:45
@bonclay7 bonclay7 marked this pull request as ready for review May 6, 2025 20:44
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2025
@ewbankkit ewbankkit self-assigned this May 31, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 31, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAMPWorkspaceConfiguration_' PKG=amp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/amp/... -v -count 1 -parallel 20  -run=TestAccAMPWorkspaceConfiguration_ -timeout 360m -vet=off
2025/05/31 17:18:37 Initializing Terraform AWS Provider...
=== RUN   TestAccAMPWorkspaceConfiguration_basic
=== PAUSE TestAccAMPWorkspaceConfiguration_basic
=== RUN   TestAccAMPWorkspaceConfiguration_defaultBucket
=== PAUSE TestAccAMPWorkspaceConfiguration_defaultBucket
=== RUN   TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== PAUSE TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT  TestAccAMPWorkspaceConfiguration_basic
=== CONT  TestAccAMPWorkspaceConfiguration_limitPerLabelSet
=== CONT  TestAccAMPWorkspaceConfiguration_defaultBucket
--- PASS: TestAccAMPWorkspaceConfiguration_defaultBucket (90.82s)
--- PASS: TestAccAMPWorkspaceConfiguration_limitPerLabelSet (97.07s)
--- PASS: TestAccAMPWorkspaceConfiguration_basic (168.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	173.909s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/amp Issues and PRs that pertain to the amp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants