This repository was archived by the owner on May 14, 2022. It is now read-only.
cmd/check: Make parsing cleaner by leveraging 'mod' #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
cmd-check-cleaner-modfile-parser
branch
from
734fd7f to
4d370a5
Compare
appilon
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#31761 may take a while to resolve, but I forked https://github.com/golang/mod which contains the most up-to-date efforts so far and copied over the missing
modfilepackage.I think this is as clean as we can make it for now.
There are no tests to verify my patch didn't break anything, which is probably task for another PR, but I promise I checked by compiling and running
checkonterraform-provider-vault(which hasgo.modwith Go version.