Make Node instance of HasName. Implement getName. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following todo formerly in src/GraphQL/Internal/Syntax/AST.hs: TODO: Just make Node implement HasName. Declared Node as instance of HasName and wrote implementation of getname for it. Because of a cyclic dependency between Name and AST, moved the Name specific code from GraphQL.Internal.Syntax.AST module into the GraphQL.Internal.Name module. Updated imports and exposures in the AST and Name modules described above. Simple import and qualified name changes to: GraphQL/Internal/Syntax/Encoder GraphQL/Internal/Syntax/Parser
Was compiling before, but Name was using Text from some place else.
jml
approved these changes
Dec 20, 2017
src/GraphQL/Internal/Name.hs
Outdated
| -- | Create a 'Name'. | ||
| -- | ||
| -- Names must match the regex @[_A-Za-z][_0-9A-Za-z]*@. If the given text does | ||
| -- not match, return Nothing. |
There was a problem hiding this comment.
I realise this is just moved from another file, but could you please change it to "return a NameError" rather than "return Nothing"?
Comment indicated that return type would be Nothing on failure, but it was in fact NameError. Amended to reflect reality.
teh
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following todo formerly in src/GraphQL/Internal/Syntax/AST.hs:
TODO: Just make Node implement HasName.
Declared Node as instance of HasName and wrote implementation of
getname for it.
Because of a cyclic dependency between Name and AST, moved the Name
specific code from GraphQL.Internal.Syntax.AST module into the
GraphQL.Internal.Name module.
Updated imports and exposures in the AST and Name modules described
above.
Simple import and qualified name changes to:
GraphQL/Internal/Syntax/Encoder
GraphQL/Internal/Syntax/Parser