-
Notifications
You must be signed in to change notification settings - Fork 32
Fix the input object example #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -48,7 +48,7 @@ example = interpretAnonymousQuery @Query root | |||
|
|||
main :: IO () | |||
main = do | |||
response <- example "{ description(dogStuff: {toy: \"bone\", likesTreats: true}) }" | |||
response <- example "{ description(dogStuff: {_toy: \"bone\", _likesTreats: true}) }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm not entirely sure what's going on here. Is there a bug for reference? Can you maybe add a description to the commit message for why the example didn't work before and why it works with this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fields in the original data structure are named with underscores and here are they are being used without underscores. That was the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What breaks because of this?
It generates this output without the change:
With the change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really we should make these automated tests or something.
We had both approved this, and there were no outstanding comments, so I merged it. |
No description provided.