Simplify GenericInputObjectFieldDefinitions #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shou
force-pushed
the
annotated-input-error-messages
branch
2 times, most recently
from
9793f68 to
30f58e4
Compare
|
Thanks for the PR. The test failure is due to our coverage ratchet. Because you improve the test coverage (yay!), you need to update the |
jml
requested changes
Aug 21, 2018
We simplify `GenericInputObjectFieldDefinitions` by using
tree-recursion, resulting in better error messages. Example
code to reproduce below, where the 'true' error is usage of
lists.
```hs
data family Test :: Nat -> Type
data instance Test 1 = Test
{ testField1 :: Int32
, testField2 :: Text
, testField3 :: Text
, testField4 :: [Int32]
} deriving (Show, Generic)
instance HasAnnotatedInputType Test
```
Before
```
• No instance for (GraphQL.Internal.API.GenericInputObjectFieldDefinitions
((S1
('MetaSel
('Just "testField1")
'NoSourceUnpackedness
'NoSourceStrictness
'DecidedLazy)
(Rec0 Int32)
:*: S1
('MetaSel
('Just "testField2")
'NoSourceUnpackedness
'NoSourceStrictness
'DecidedLazy)
(Rec0 Text))
:*: (S1
('MetaSel
('Just "testField3")
'NoSourceUnpackedness
'NoSourceStrictness
'DecidedLazy)
(Rec0 Text)
:*: S1
('MetaSel
('Just "testField4")
'NoSourceUnpackedness
'NoSourceStrictness
'DecidedLazy)
(Rec0 [Int32]))))
arising from a use of ‘GraphQL.Internal.API.$dmgetAnnotatedInputType’
• In the expression:
GraphQL.Internal.API.$dmgetAnnotatedInputType @(Test 1)
In an equation for ‘QL.getAnnotatedInputType’:
QL.getAnnotatedInputType
= GraphQL.Internal.API.$dmgetAnnotatedInputType @(Test 1)
In the instance declaration for ‘QL.HasAnnotatedInputType (Test 1)’
|
72 | instance QL.HasAnnotatedInputType (Test 1)
|
```
After
```
• No instance for (QL.HasAnnotatedInputType [Int32])
arising from a use of ‘GraphQL.Internal.API.$dmgetAnnotatedInputType’
• In the expression:
GraphQL.Internal.API.$dmgetAnnotatedInputType @(Test 1)
In an equation for ‘QL.getAnnotatedInputType’:
QL.getAnnotatedInputType
= GraphQL.Internal.API.$dmgetAnnotatedInputType @(Test 1)
In the instance declaration for ‘QL.HasAnnotatedInputType (Test 1)’
|
72 | instance QL.HasAnnotatedInputType (Test 1)
|
```
Shou
force-pushed
the
annotated-input-error-messages
branch
from
30f58e4 to
5747b88
Compare
|
Done! Tests are looking good now. |
Closed
|
@jml anything else I can do to get the PR merged? |
jml
approved these changes
Aug 29, 2018
|
All good. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We simplify
GenericInputObjectFieldDefinitionsby usingtree-recursion, resulting in better error messages. Example
code to reproduce below, where the 'true' error is usage of
lists.
Before
After