Add roundtrip tests for all common types #29
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dmjio
commented
Sep 25, 2023
•
dmjio
commented
- Should QuickCheck iso all types through a table
dmjio
force-pushed
the
roundtrip-tests
branch
from
cefa9fb to
6228c64
Compare
apkhandkar
reviewed
Oct 1, 2023
apkhandkar
reviewed
Oct 1, 2023
apkhandkar
reviewed
Oct 2, 2023
| arbitrary = | ||
| TestTable | ||
| <$> arbitrary | ||
| <*> arbitrary -- choose (- 2^12, 2 ^ 12) |
There was a problem hiding this comment.
The number(12,0) fields above have a range of [999999999999, -999999999999], these tests fail with a "value larger than specified precision" error because Int/Int64 are wider. choose (-(10^12 - 1), 10^12 -1) could be used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.