Add Manual Storable Instances for DPIXid and VersionInfo (#26) #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tusharad adding a test would be helpful |
…sharad/oracle-simple into feature/optimizing_storable_instances
|
Added round-trip test cases for VersionInfo and DPIXid to ensure their Storable instances are working correctly. For this, I had to expose DPIXid from the Transaction module to make it accessible for testing. Also added Eq instance for DPIXid (Not sure why it was missing previously, but it is necessary for the test assertions). This commit is related to Issue #20, which discusses adding round-trip instance tests. Let me know if anything else required. Thanks. |
|
LGTM 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #26 by implementing manual Storable instances for DPIXid and VersionInfo, instead of relying on GStorable.
I kindly request a review of Implementation (whether it aligned with best practices).
If the approach is deemed correct, I intend to implement manual Storable instances for other types as part of this refactoring effort. Feel free to suggest any changes, optimizations, or best practices that could enhance the implementation. Thank you for your time and guidance!
@apkhandkar @dmjio