Skip to content

Fix mistake in BuildInfo.Lens.hs #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mistake in BuildInfo.Lens.hs #10609

wants to merge 1 commit into from
+1 −1

Conversation

andreabedini
Copy link
Collaborator 

  cxxSources f s = fmap (\x -> s{T.cSources = x}) (f (T.cxxSources s))

should be

  cxxSources f s = fmap (\x -> s{T.cxxSources = x}) (f (T.cxxSources s))

@andreabedini
Fix mistake in BuildInfo.Lens.hs
579e653 
```
  cxxSources f s = fmap (\x -> s{T.cSources = x}) (f (T.cxxSources s))
```
should be
```
  cxxSources f s = fmap (\x -> s{T.cxxSources = x}) (f (T.cxxSources s))
```
ffaf1
ffaf1 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template missing.

commit: fc3dc42
How is it possible that this was never spotted in almost eight years? Does nobody use lenses? Do we need to add some tests?

@andreabedini
Copy link
Collaborator Author

Template missing.

Guilty as charged. For a change this obvious and small, the mental effort required to process the template was higher than the one required to fix the bug. I mean no disrespect though.

@andreabedini andreabedini added the merge me Tell Mergify Bot to merge label Dec 2, 2024
@ffaf1
Copy link
Collaborator

ffaf1 commented Dec 2, 2024

No worries. This needs a changelog, does it not?

Mikolaj
Mikolaj requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this does not look like an obvious exception from the changelog rule. But well spotted!

@Mikolaj
Copy link
Member

Mikolaj commented Apr 10, 2025

@andreabedini: a humble ping?

@Mikolaj Mikolaj removed the merge me Tell Mergify Bot to merge label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikolaj Mikolaj Mikolaj requested changes

@ffaf1 ffaf1 ffaf1 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabedini @ffaf1 @Mikolaj