Skip to content

standalone tests for cabal init #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2021

Conversation

ptkato
Copy link
Collaborator

@ptkato ptkato commented Jun 3, 2021

This PR adds a new functionality to cabal init, standalone tests, as discussed in #7410.

Closes #7410.


Please include the following checklist in your PR:

@ptkato
Copy link
Collaborator Author

ptkato commented Jun 3, 2021

@emilypi here we go, I do believe these changes cover everything in that issue, yes?

Another point to think about, the --tests flag might have become a little too cryptic.

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some comments, and I think we should golden test this.

{ initializeTestSuite = Flag True
, packageType = NoFlag
} _ = return TestSuite
getPackageType flags act = fromFlagOrPrompt (packageType flags) act
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. that's easy i suppose.

@ptkato ptkato force-pushed the cabal-init-standalone-tests branch 2 times, most recently from 9d5f89b to f6c98b5 Compare June 5, 2021 14:04
ptkato added a commit to ptkato/cabal that referenced this pull request Jun 8, 2021
@ptkato ptkato marked this pull request as ready for review June 8, 2021 18:42
ptkato added a commit to ptkato/cabal that referenced this pull request Jun 8, 2021
@ptkato ptkato force-pushed the cabal-init-standalone-tests branch from d598c74 to db1c3e9 Compare June 8, 2021 20:27
@ptkato
Copy link
Collaborator Author

ptkato commented Jun 8, 2021

Hello there @emilypi @fgaz,

I believe this one is ready for some reviewing action.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very solid from the surface.

@ptkato ptkato force-pushed the cabal-init-standalone-tests branch from 2c27ac5 to 7954c10 Compare June 23, 2021 00:28
@ptkato ptkato merged commit 3675929 into haskell:master Jun 24, 2021
fendor pushed a commit to fendor/cabal that referenced this pull request Jul 12, 2021
fendor pushed a commit to fendor/cabal that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal init --tests does not create any tests if not using --lib{andexe}
3 participants