-
Notifications
You must be signed in to change notification settings - Fork 710
standalone tests for cabal init
#7424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@emilypi here we go, I do believe these changes cover everything in that issue, yes? Another point to think about, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Some comments, and I think we should golden test this.
{ initializeTestSuite = Flag True | ||
, packageType = NoFlag | ||
} _ = return TestSuite | ||
getPackageType flags act = fromFlagOrPrompt (packageType flags) act |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. that's easy i suppose.
cabal-install/src/Distribution/Client/Init/Interactive/Command.hs
Outdated
Show resolved
Hide resolved
cabal-install/src/Distribution/Client/Init/Interactive/Command.hs
Outdated
Show resolved
Hide resolved
9d5f89b
to
f6c98b5
Compare
d598c74
to
db1c3e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very solid from the surface.
cabal-install/tests/UnitTests/Distribution/Client/Init/NonInteractive.hs
Outdated
Show resolved
Hide resolved
cabal-install/tests/UnitTests/Distribution/Client/Init/NonInteractive.hs
Outdated
Show resolved
Hide resolved
2c27ac5
to
7954c10
Compare
This PR adds a new functionality to
cabal init
, standalone tests, as discussed in #7410.Closes #7410.
Please include the following checklist in your PR: