No bootstrapping #170
Closed
No bootstrapping #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
int-index
force-pushed
the
no-bootstrapping
branch
from
8d9a8ea to
0f4360b
Compare
Before this patch, building 'happy' required a pre-built binary of 'happy'. This was elegant in the same way a self-hosting compiler is elegant. But it also made building purely from source more complicated than needed. This patch introduces a small, bespoke parsing library, and applies it for parsing .y and .ly files. Now 'happy' doesn't depend on itself, and can be built using just GHC.
int-index
force-pushed
the
no-bootstrapping
branch
from
0f4360b to
232ee4f
Compare
|
We discussed this with @simonmar elsewhere and concluded that a better solution (for now) would be to check in Happy-generated files. |
Merged
wincent
added a commit
to wincent/docvim
that referenced
this pull request
Sep 1, 2020
Seeing as I finally got local bin/golden and bin/accept working, as described here: https://twitter.com/wincent/status/1300865628534910976 haskell/happy#170 git clone https://github.com/simonmar/happy.git cd happy git hub get 170 # custom command, pulls down that PR make sdist && cabal install cd .. bin/golden bin/accept
|
Could we do it both ways, using compiler flags or something to switch between the too? Beyond bootstrapping, I think this is useful to test happy. |
|
@simonmar Maybe see:
It is nice to have the submodule so we can have GHC branches using alex/happy branches, whether to demonstrate new features, or as in the recent case, that a branch changing the primops works at all. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, building
happyrequired a pre-built binary ofhappy. This was elegant in the same way a self-hosting compiler is elegant. But it also made building purely from source more complicated than needed.This patch introduces a small, bespoke parsing library, and applies it for parsing
.yand.lyfiles.Now
happydoesn't depend on itself, and can be built using just GHC.Closes #169