Improve error message for badly-formatted json #166

glittershark · 2016-01-10T18:56:44Z

❯ echo '{"cmd":"base:commands","params":{"plugin": "hare"}}' | hie --one-shot | jq
{
  "error": {
    "msg": "FromJSONError \"failed to parse field params: empty\"",
    "code": "ParseError",
    "info": null
  }
}

Use Aeson's built-in `with<type>` functions, plus a custom error message at the end of the ParamValP parser's Alternative chain to improve error messages when parsing JSON requests. Before: ------- ``` ❯ echo '{"cmd":"base:commands","params":{"plugin": "hare"}}' | hie --one-shot | jq { "error": { "msg": "FromJSONError \"failed to parse field params: empty\"", "code": "ParseError", "info": null } } ``` After: ------ ``` ❯ echo '{"cmd":"base:commands","params":{"plugin": "hare"}}' | stack exec -- hie --one-shot | jq { "error": { "msg": "FromJSONError \"failed to parse field params: expected text, file, or position object, encountered String\"", "code": "ParseError", "info": null } } ``` Closes haskell#166

glittershark mentioned this issue Jan 10, 2016

Improve error messages in JSON parsing #167

Merged

cocreature closed this as completed in #167 Jan 12, 2016

alanz added this to the prehistory milestone Feb 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error message for badly-formatted json #166

Improve error message for badly-formatted json #166

glittershark commented Jan 10, 2016

Improve error message for badly-formatted json #166

Improve error message for badly-formatted json #166

Comments

glittershark commented Jan 10, 2016