This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Bump deps and adapt to new apis #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res <- catchException $ hlint hlintOpts | ||
| logm $ "applyHint:res=" ++ show res | ||
| -- res <- hlint hlintOpts | ||
| (flags,classify,hint) <- autoSettings |
There was a problem hiding this comment.
You should rather use argSettings, so we can eventually pass through any extra flags the user has set.
See alanz@97ccf82#diff-7b1a90d13e6fd0644f04b15c6c20befeR106, from my branch updating apply-refact
There was a problem hiding this comment.
Thanks, updated. Sorry for duplicating your efforts, I didn’t see that you were already working on it.
cocreature
force-pushed
the
bump-snapshot
branch
from
37785a7 to
28fd70b
Compare
cocreature
force-pushed
the
bump-snapshot
branch
from
28fd70b to
2796e8a
Compare
| - HaRe-0.8.2.1 | ||
| - rosezipper-0.2 | ||
| - syz-0.2.0.0 | ||
| - hlint-1.9.26 |
There was a problem hiding this comment.
I am pretty sure this version of hlint is in the current nightly, can be removed from this file
There was a problem hiding this comment.
I thought I checked but apparently I haven’t. Just pushed an update.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two minor changes here:
IdeError. Previously we had a Maybe Value which causes issues with the new aeson (I haven’t looked into why we didn’t run into it with the old version) since bothNothingandJust Nullare encoded toNullso we no longer have an isomorphism. Since we already have aNullvalue inValueand I don’t think we need the distinction here, this is now just aValue.