This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Use UUIDs for commands #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client This is used when a client has more than one project microsoft/vscode-languageserver-node#333 (comment)
alanz
reviewed
Jun 13, 2018
| let commands = ["hare:demote", "applyrefact:applyOne"] | ||
| uuids :: [UUID] | ||
| uuids = randoms gen | ||
| return $ BM.fromList (zip commands uuids) |
There was a problem hiding this comment.
I think it might be good to include the original command too, so if the UUID is abcdef, then use a command string of hare:demote:abcdef.
It will make interpreting logs etc much easier.
There was a problem hiding this comment.
And then we only need one UUID per session too, come to think of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when starting multiple instances of HIE for the same client, it an errors due to registering the same commands multiple times in the initialise response that we send. This happens when creating a multi-root/project workspace in VS Code.
This was discussed here and the suggested solution was to use UUIDs to register commands.
This PR changes the server to register random UUIDs, and maps back and forth between them in code action and execute command requests. You can still send an execute request for "hare:demote" as well as the new random UUID for it, and have the same command executed.