Skip to content

Bullet points in hover #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukel97 opened this issue Jun 1, 2020 · 9 comments
Closed

Bullet points in hover #142

lukel97 opened this issue Jun 1, 2020 · 9 comments

Comments

@lukel97
Copy link
Collaborator

lukel97 commented Jun 1, 2020

There's these funky bullet points in the hover request that render quite weirdly in VS code

image

I presume these aren't meant to be there? Or at least formatted differently

@jneira
Copy link
Member

jneira commented Jun 1, 2020

I've noticed them too, i think they come from the upstream ghcide/hls

@googleson78
Copy link
Contributor

unrendered, for reference:
2020-06-01-164159_481x188_scrot

@alanz
Copy link
Collaborator

alanz commented Jun 1, 2020

I put them there. The default rendering of "* * *" in emacs-lsp is broken, it makes the hover window take up the entire width of the frame

@alanz
Copy link
Collaborator

alanz commented Jun 1, 2020

See alanz/ghcide@02740c8

@lukel97
Copy link
Collaborator Author

lukel97 commented Jun 1, 2020

Ah, I see now that these used to be horizontal rules. But I'm not even sure if VS code rendered them properly either in the first place: I just tested out * * * again and I'm getting this

image

Perhaps the ultimate horizontal rule is just a \n. But hopefully the clients will get around to fixing this at some point, at which we can maybe switch back. microsoft/vscode#98982

@alanz
Copy link
Collaborator

alanz commented Jun 1, 2020

well, if the bullet does not work, a newline is an option.

@alanz
Copy link
Collaborator

alanz commented Jun 4, 2020

FYI, the emacs issue is at emacs-lsp/lsp-ui#442

@lukel97
Copy link
Collaborator Author

lukel97 commented Jun 8, 2020

#150

@lukel97 lukel97 closed this as completed Jun 8, 2020
@lukel97
Copy link
Collaborator Author

lukel97 commented Jun 12, 2020

The HRs have been fixed in vscode now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants