Skip to content

Generalise the formatter plugin infrastructure #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alanz opened this issue Feb 5, 2020 · 4 comments
Closed

Generalise the formatter plugin infrastructure #40

alanz opened this issue Feb 5, 2020 · 4 comments
Assignees

Comments

@alanz
Copy link
Collaborator

alanz commented Feb 5, 2020

We now have one formatter implemented, Ormolu via #33

This has been done in a "make it work" way, and I merged it to get concrete progress into the project.

We need to extract some sort of formatter plugin support from this, so it is easy to plug in other formatters.

@alanz alanz self-assigned this Feb 6, 2020
@alanz
Copy link
Collaborator Author

alanz commented Feb 6, 2020

I am going to add floskell, and see what ends up common

@Ailrun
Copy link
Member

Ailrun commented Jun 4, 2020

If there's no one working on stylish-haskell plugin, I will make that.

@Ailrun
Copy link
Member

Ailrun commented Jun 6, 2020

PR has been made: #146

@jneira
Copy link
Member

jneira commented Sep 23, 2020

Afaik there is a common formatter module with reusable functions for all formatters: https://github.com/haskell/haskell-language-server/blob/master/hls-plugin-api/src/Ide/Plugin/Formatter.hs
It can be extended if we discover more shared functionality

@jneira jneira closed this as completed Sep 23, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
Add code action for fixing misspelled variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants