-
-
Notifications
You must be signed in to change notification settings - Fork 389
Add support for ghc-8.10.4 and drop it for ghc-8.10.1 #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jneira
commented
Feb 8, 2021
- We dont have time and resources to support all possible ghc versions (as commented here) so, as we are supporting 8.8.2..8.8.4 i propose only support the last three minor version of each major version too for 8.10
- This pr drops the unused (afaik) ci azure config
- Closes Add ghc-8.10.4 support #1317
ghc8102 = extended (pkgs.haskell.packages.ghc8102.override sharedOverrides); | ||
ghc8103 = extended (pkgs.haskell.packages.ghc8103.override sharedOverrides); | ||
ghc8104 = extended (pkgs.haskell.packages.ghc8104.override sharedOverrides); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it this will work out of the box
What do you think in make a github release after adding ghc-8.10.4 support?, it would have hiedb included |
When ci is green i will remove the github required checks for ghc-8.10.1 and add ghc-8.10.4 ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, Thanks. I hope there's no one left behind with GHC 8.10.1...
I'm OK with a release. There have been no bug reports about hiedb so far, so either its working as intended (yay!), or nobody is using it. If its the latter, I'm ready for people to start dropping the bug reports once they start using it. |
I need some window time to
and no merge other pr's with a failing test suite between 1 and 2 Then we should update the rest of pr's (that is enforced by github) |
I think we can do 1. and 3. together. If so, all other PRs cannot be merged until this one is merged. (and so we don't need a special time window) |
yeah, I didn't want block anyone though, I will wait until I come home and will change them if I can't do the switch &merge fast |