-
-
Notifications
You must be signed in to change notification settings - Fork 389
Add test for multi-component goto def and make runLanguageServer responsible for hiedb #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onsible for hiedb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner, thanks. I have but one request, can we make the location of the hiedb file configurable?
I don't have any strong opinions on how to expose it, but in case it helps the SessionLoadingOptions already allow to override the location of the cache dirs, so maybe the easiest thing to do would be to add another field in that record for the hiedb.
@pepeiborra can I do that in another PR tomorrow? |
Are you keen on landing this PR today? |
No, its just that the other changes in this PR are necessary for making the test run. |
@pepeiborra OK, I've made it configurable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
Test for #1357
Involved re-jigging 'runWithDb' to be within the callback to 'runLanguageServer' so that the database location
is derived from the 'rootPath' of the LSP session, and not the starting CWD of the ghcide process.
I have verified that the test fails without the mentioned commit.