Skip to content

Use runtime ghc libdir for ghc-exactprint and ghc-8.10 #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2021
Merged

Use runtime ghc libdir for ghc-exactprint and ghc-8.10 #1451

merged 5 commits into from
Feb 28, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 27, 2021

@jneira jneira requested review from alanz and Ailrun February 27, 2021 14:33
@jneira jneira mentioned this pull request Feb 27, 2021
Closed
@jneira
Copy link
Member Author

jneira commented Feb 27, 2021

This must have a regression test but it would suppose:

  • using ghc inits default location to install hls
  • moving the ghc installation to other dir
  • set that location in path
  • run the tests that might be broken for the previous step
  • restore the original ghc installation path

Other option could be test the executables, being careful to change the ghc installation, see #595

@jneira
Copy link
Member Author

jneira commented Feb 27, 2021

I have to update stack.yaml's

Ailrun
Ailrun reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, waiting for regression tests and stack.yaml updates...

Ailrun
Ailrun reviewed Feb 27, 2021
View reviewed changes
plugins/hls-hlint-plugin/hls-hlint-plugin.cabal
build-depends: ghc ^>= 8.10

else
build-depends:
, ghc
, ghc-lib ^>= 8.10.2.20200916
, ghc-lib ^>= 8.10.4.20210206
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK to not update cabal.project index?

Copy link
Member Author

@jneira jneira Feb 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that ghc-lib version was released on 2021-02-06T16:51:55Z

@jneira
Copy link
Member Author

jneira commented Feb 27, 2021

Thanks, waiting for regression tests and stack.yaml updates...

If you dont mind i would prefer to merge this without the test, to fix the issue asap.
That test is more complex than the regular ones and maybe the right way would be #595

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Feb 28, 2021
@mergify mergify bot merged commit 43b33a5 into haskell:master Feb 28, 2021
@jneira jneira deleted the fix-runtime-libdir branch February 28, 2021 09:37
@jneira jneira mentioned this pull request Feb 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@alanz alanz Awaiting requested review from alanz

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hlint seeking unavailable file /opt/ghc/8.8.4/lib/ghc-8.8.4/settings
2 participants
@jneira @Ailrun