-
-
Notifications
You must be signed in to change notification settings - Fork 389
attempt to fix Nix build #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to fix Nix build #2136
Conversation
The Nix CI job is failing in a confusing way - it's trying to build the development shell with multiple versions of GHC in the same job, and failing for 9.0.1. This should probably be done using a matrix instead. @berberman do you remember if this was a deliberate choice? The failure is not related to this PR, but it's preventing us from finding out whether the PR works or not |
Sorry for being inactive these days, I was pretty busy. What Now I don't have nix environment around, but I guess to fix the jobs, at least we shoud:
to something like lsp = hself.lsp_1_2_0_1;
lsp-types = hself.lsp-types_1_3_0_1;
lsp-test = hself.lsp-test_0_14_0_1; because these packages we override the sources of are already in nixpkgs
because we need ormolu 0.2.0.0 in GHC 9.0.1 (#2086) |
@peterbecich hi! thanks for trying to fix the nix build, have you got the chance to check the suggestion above? |
So I was poking at doing basically the same thing as this PR requests without noticing it already existed and did all the requested things from here. See #2159. |
Thank you @pepeiborra , @berberman , @jneira and @lf- ; sorry for my late response. Closing in favor of #2159 |
nix-build
succeeds on this branchSHA acquired with
nix-prefetch-url https://hackage.haskell.org/package/lsp-types-1.3.0.1/lsp-types-1.3.0.1.tar.gz --unpack