-
-
Notifications
You must be signed in to change notification settings - Fork 389
flake: remove the 'follows' directive #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nixFlake suffers from a bug when using "follows" keyword: NixOS/nix#3602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to make sure that formatters in pre-commit hooks are consistent (#1408), so I think the follow of nixpkgs is required. For flake-utils, I agree with removing that follow.
the "follow" is broken in nix which means I can't use the flake without a fork. Alternatively, could we :
|
I don't think that's a good idea, since it causes extra maintenance
Actually we already do this: haskell-language-server/flake.nix Line 137 in 48221c7
So maybe we don't need "follow" nixpkgs at all, and this PR may work. Could you try executing the pre-commit hook? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming, then we are good to go
nixFlake suffers from a bug when using "follows" keyword:
NixOS/nix#3602
I think the (possibly) extra-downloads is worth having the peace of mind that it always works.