-
-
Notifications
You must be signed in to change notification settings - Fork 389
Qualify imported names plugin #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ge-server Keep up to date with master.
First of all many thanks for working on this useful feature. Will do a review asap. Hard to believe but i've not found any issue about this feature. It is not required but if someone knows any of the issues are related with this please note it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm the plugin look really great
could you update the features documentation adding it as well, thanks!
Will merge after releasing 1.5.1, thanks for your patience 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I ve just observed the .cabal file does not include the readme and test data files in source-extra-files, take a look to other plugins .cabal to see the glob syntax available
thanks
I looked at some of the other plugins and they don't seem to include the README.md or gif, but I included them anyway. |
yeah you are right, we have to eventually add it in the rest of plugins, thanks for doing it for this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this nice plugin
Purpose
If you have unqualified names imported by a unqualified import and you want to qualify them, this plugin can do it.
Usage
Qualify imported names
.Features
I think this plugin is complete but I'm uncertain about GHC 9+.