-
-
Notifications
You must be signed in to change notification settings - Fork 389
Enable aarch64-darwin
in flake.nix
#2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently only GHC 8.10.7 builds on `aarch64-darwin` after this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to see you here and thanks for fix the builds for that arch 🙂
lgtm but will wait for an actual nix user review to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It seems that GitHub actions don't support aarch64-darwin yet. Is there anyway to test the build?
we are building aarch64-darwin in the gitlab repo, only for ghc-8.10.7, it would be matter to change the gitlab CI config to add a job using the flake and several ghcs haskell-language-server/.gitlab-ci.yml Line 211 in ee0a0cc
but it can be done in another pr imo |
CircleCI builds awaited by the PR are not present at the dashboard queue. |
[skip circleci] |
Currently only GHC 8.10.7 builds on
aarch64-darwin
after this change