-
-
Notifications
You must be signed in to change notification settings - Fork 389
Add support for Fourmolu 0.14.0.0 #3796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
You need to bump the |
2617cf5
to
838695d
Compare
838695d
to
c655372
Compare
Nope 😄 Just pushed without testing. Sorry, just tested and it should work now |
I wondered but I didn't think you could have done the refactoring like that 😂 |
Just made good guesses in the refactor? 😂 Anyway, the test failures are unrelated. The Nix failure does seem relevant
but I'm not sure how to update the Nix files |
I'm thinking is it possible to separate nix stuffs from the hls repo🤔️ |
That's why the check is not required :) |
This was just released: https://github.com/fourmolu/fourmolu/releases/tag/v0.14.0.0
Also includes some minor refactoring. I think it should be pretty uncontroversial, but if not, I can break out into a separate PR