Skip to content

Simplify cabal.project #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 14 additions & 39 deletions cabal.project
Original file line number Diff line number Diff line change
@@ -34,47 +34,26 @@ packages:
./plugins/hls-refactor-plugin
./plugins/hls-overloaded-record-dot-plugin

-- Standard location for temporary packages needed for particular environments
-- For example it is used in the project gitlab mirror to help in the MAcOS M1 build script
-- See https://github.com/haskell/haskell-language-server/blob/master/.gitlab-ci.yml
optional-packages: vendored/*/*.cabal
index-state: 2023-10-06T06:12:29Z

tests: True
test-show-details: direct

-- mfsolve has duplicate instances in its test suite
-- See: https://github.com/kuribas/mfsolve/issues/8
package mfsolve
tests: False
Comment on lines -46 to -47
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not needed anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how it ever was - unless we had a srp for mfsolve at some point.


package *
ghc-options: -haddock
test-show-details: direct
benchmarks: True

write-ghc-environment-files: never

index-state: 2023-10-06T06:12:29Z
-- Make sure dependencies are build with haddock so we get
-- haddock shown on hover
package *
ghc-options: -haddock

constraints:
-- C++ is hard to distribute, especially on older GHCs
-- See https://github.com/haskell/haskell-language-server/issues/3822
text -simdutf,
-- For GHC 9.4, older versions of entropy fail to build on Windows
entropy >= 0.4.1.10,
-- For GHC 9.4
basement >= 0.0.15,
-- For GHC 9.4
hw-prim >= 0.6.3.2,
hyphenation +embed,
-- remove this when hlint sets ghc-lib to true by default
-- https://github.com/ndmitchell/hlint/issues/1376
hlint +ghc-lib,
ghc-check -ghc-check-use-package-abis,
ghc-lib-parser-ex -auto,
stylish-haskell +ghc-lib,
fourmolu -fixity-th,
setup.happy == 1.20.1.1,
happy == 1.20.1.1,
filepath installed,
-- Centos 7 comes with an old gcc version that doesn't know about
-- the flag '-fopen-simd', which blocked the release 2.2.0.0.
-- We want to be able to benefit from the performance optimisations
@@ -94,20 +73,17 @@ source-repository-package
tag: 7a0af7a8fd38045fd15fb13445bdcc7085325460
-- END DELETE

allow-newer:
-- ghc-9.4
ekg-json:base,
ekg-wai:time,

if impl(ghc >= 9.5)
if impl(ghc >= 9.1)
-- ekg packagess are old and unmaintained, but we
-- don't rely on them for the mainline build, so
-- this is okay
allow-newer:
-- ghc-9.6
ekg-core:ghc-prim,
stm-hamt:transformers,
ekg-json:base,
ekg-wai:time,
ekg-core:ghc-prim

if impl(ghc >= 9.7)
allow-newer:
-- ghc-9.8
base,
template-haskell,
ghc,
@@ -122,7 +98,6 @@ if impl(ghc >= 9.7)
unix,
deepseq,

if impl(ghc >= 9.7)
repository head.hackage.ghc.haskell.org
url: https://ghc.gitlab.haskell.org/head.hackage/
secure: True
3 changes: 3 additions & 0 deletions haskell-language-server.cabal
Original file line number Diff line number Diff line change
@@ -570,6 +570,9 @@ test-suite wrapper-test
main-is: Main.hs

benchmark benchmark
-- Depends on shake-bench which is unbuildable after this point
if impl(ghc >= 9.5)
buildable: False
type: exitcode-stdio-1.0
default-language: Haskell2010
ghc-options: -Wall -Wno-name-shadowing -threaded
2 changes: 1 addition & 1 deletion plugins/hls-hlint-plugin/hls-hlint-plugin.cabal
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ library
, ghc-exactprint >=0.6.3.4
, ghcide == 2.4.0.0
, hashable
, hlint < 3.7
, hlint >= 3.5 && < 3.7
, hls-plugin-api == 2.4.0.0
, lens
, lsp
1 change: 1 addition & 0 deletions shake-bench/shake-bench.cabal
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ source-repository head
location: https://github.com/haskell/haskell-language-server.git

library
-- Depends on Chart which is unbuildable after this point
if impl(ghc >= 9.5)
buildable: False
exposed-modules: Development.Benchmark.Rules
5 changes: 0 additions & 5 deletions stack-lts21.yaml
Original file line number Diff line number Diff line change
@@ -66,11 +66,6 @@ flags:
pedantic: true
retrie:
BuildExecutable: false
# Stack doesn't support automatic flags.
hyphenation:
embed: true
stylish-haskell:
ghc-lib: true

nix:
packages: [ icu libcxx zlib ]
3 changes: 0 additions & 3 deletions stack.yaml
Original file line number Diff line number Diff line change
@@ -67,9 +67,6 @@ flags:
pedantic: true
retrie:
BuildExecutable: false
# Stack doesn't support automatic flags.
hyphenation:
embed: true

nix:
packages: [ icu libcxx zlib ]