Skip to content

Fix -Wall and -Wunused-packages in stylish-haskell plugin #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Fix -Wall and -Wunused-packages in stylish-haskell plugin #4015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28d4ede
Fix -Wall and -Wunused-packages in stylish-haskell plugin
jhrcek Jan 24, 2024
5e7d640
Format
jhrcek Jan 24, 2024
2e73e7d
Merge branch 'master' into jhrcek/unused-packages-stylish-haskell
mergify[bot] Jan 24, 2024
5c312ae
Merge branch 'master' into jhrcek/unused-packages-stylish-haskell
mergify[bot] Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plugins/hls-stylish-haskell-plugin/hls-stylish-haskell-plugin.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ source-repository head
type: git
location: https://github.com/haskell/haskell-language-server.git

common warnings
ghc-options: -Wall -Wunused-packages

library
import: warnings
exposed-modules: Ide.Plugin.StylishHaskell
hs-source-dirs: src
build-depends:
, base >=4.12 && <5
, directory
, filepath
, ghc
, ghc-boot-th
, ghcide == 2.6.0.0
, hls-plugin-api == 2.6.0.0
Expand All @@ -38,6 +41,7 @@ library
default-language: Haskell2010

test-suite tests
import: warnings
type: exitcode-stdio-1.0
default-language: Haskell2010
hs-source-dirs: test
Expand Down
3 changes: 2 additions & 1 deletion plugins/hls-stylish-haskell-plugin/src/Ide/Plugin/StylishHaskell.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import Control.Monad.Except (throwError)
import Control.Monad.IO.Class
import Data.Text (Text)
import qualified Data.Text as T
import Development.IDE hiding (pluginHandlers)
import Development.IDE hiding (getExtensions,
pluginHandlers)
import Development.IDE.Core.PluginUtils
import Development.IDE.GHC.Compat (ModSummary (ms_hspp_opts),
extensionFlags)
Expand Down