Skip to content

Add -Wunused-packages to common warnings #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Add -Wunused-packages to common warnings #4053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aacef4c
Add -Wunused-packages to common warnings
jhrcek Feb 5, 2024
1c59421
Get rid of common deps
jhrcek Feb 5, 2024
0721987
Wrapper needs process on windows
jhrcek Feb 6, 2024
786089f
Refine
jhrcek Feb 6, 2024
50c3891
Does it work like this?
jhrcek Feb 6, 2024
6d20721
More cleanups in ghcide
jhrcek Feb 7, 2024
74830aa
Fix build with stack
jhrcek Feb 7, 2024
47a9dcd
Also fix stack --test
jhrcek Feb 7, 2024
d01aefd
Less noisy workaround
jhrcek Feb 7, 2024
1f4257b
Merge branch 'master' into jhrcek/add-Wunused-packages-to-common-warn…
jhrcek Feb 8, 2024
9359811
Fix new warnings
jhrcek Feb 8, 2024
771c370
Merge branch 'master' into jhrcek/add-Wunused-packages-to-common-warn…
jhrcek Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions ghcide/ghcide.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ homepage:
https://github.com/haskell/haskell-language-server/tree/master/ghcide#readme

bug-reports: https://github.com/haskell/haskell-language-server/issues
tested-with: GHC == 9.8.1 || ==9.6.4 || ==9.4.8 || ==9.2.8
tested-with: GHC ==9.8.1 || ==9.6.4 || ==9.4.8 || ==9.2.8
extra-source-files:
CHANGELOG.md
README.md
Expand Down Expand Up @@ -215,11 +215,8 @@ library
Development.IDE.Types.Action

if flag(pedantic)
-- We eventually want to build with Werror fully, but we haven't
-- finished purging the warnings, so some are set to not be errors
-- for now
ghc-options:
-Werror -Wwarn=unused-packages
-Werror

if flag(ekg)
build-depends:
Expand Down Expand Up @@ -283,13 +280,6 @@ executable ghcide
if !flag(executable)
buildable: False

if flag(ekg)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ekg dep is only direct dep of ghcide library, not of the executable.

build-depends:
, ekg-core
, ekg-wai

cpp-options: -DMONITORING_EKG

test-suite ghcide-tests
import: warnings
type: exitcode-stdio-1.0
Expand All @@ -310,14 +300,6 @@ test-suite ghcide-tests
, extra
, filepath
, fuzzy
--------------------------------------------------------------
-- The MIN_VERSION_ghc macro relies on MIN_VERSION pragmas
-- which require depending on ghc. So the tests need to depend
-- on ghc if they need to use MIN_VERSION_ghc. Maybe a
-- better solution can be found, but this is a quick solution
-- which works for now.
--------------------------------------------------------------
, ghc
, ghcide
, hls-plugin-api
, lens
Expand Down
Loading