Skip to content

Enable floskell and hlint plugins for ghc 9.8 #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions haskell-language-server.cabal
Original file line number Diff line number Diff line change
@@ -606,7 +606,7 @@ flag hlint
manual: True

common hlint
if flag(hlint) && (impl(ghc < 9.8.0) || flag(ignore-plugins-ghc-bounds))
if flag(hlint)
build-depends: haskell-language-server:hls-hlint-plugin
cpp-options: -Dhls_hlint

@@ -1278,7 +1278,7 @@ flag floskell
manual: True

common floskell
if flag(floskell) && (impl(ghc < 9.7) || flag(ignore-plugins-ghc-bounds))
if flag(floskell)
build-depends: haskell-language-server:hls-floskell-plugin
cpp-options: -Dhls_floskell

7 changes: 7 additions & 0 deletions test/testdata/schema/ghc98/default-config.golden.json
Original file line number Diff line number Diff line change
@@ -73,6 +73,13 @@
},
"globalOn": true
},
"hlint": {
"codeActionsOn": true,
"config": {
"flags": []
},
"diagnosticsOn": true
},
"importLens": {
"codeActionsOn": true,
"codeLensOn": true
18 changes: 18 additions & 0 deletions test/testdata/schema/ghc98/vscode-extension-schema.golden.json
Original file line number Diff line number Diff line change
@@ -171,6 +171,24 @@
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.hlint.codeActionsOn": {
"default": true,
"description": "Enables hlint code actions",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.hlint.config.flags": {
"default": [],
"markdownDescription": "Flags used by hlint",
"scope": "resource",
"type": "array"
},
"haskell.plugin.hlint.diagnosticsOn": {
"default": true,
"description": "Enables hlint diagnostics",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.importLens.codeActionsOn": {
"default": true,
"description": "Enables importLens code actions",