Skip to content

Perform memory measurement on SIGUSR1 #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 2, 2021
Merged

Perform memory measurement on SIGUSR1 #761

merged 7 commits into from
Jan 2, 2021

Conversation

pepeiborra
Copy link
Collaborator

No description provided.

ndmitchell
ndmitchell reviewed Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code deserve some documentation somewhere? E.g. in some developer tricks guide or similar?

Where is the requirement for Ord coming from? Some kind of Map? Can we switch it to a HashMap and avoid the Ord everywhere?

@pepeiborra
Copy link
Collaborator Author

pepeiborra commented Dec 31, 2020 •
edited
Loading

Does this code deserve some documentation somewhere? E.g. in some developer tricks guide or similar?

I have added a note on the use of SIGUSR1 to the existing docs in ghcide/doc/opentelemetry.md

ndmitchell
ndmitchell approved these changes Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@ndmitchell ndmitchell mentioned this pull request Dec 31, 2020
Open
@pepeiborra pepeiborra merged commit 9649165 into haskell:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndmitchell ndmitchell ndmitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepeiborra @ndmitchell @jneira