Skip to content

Add dependen-sum lower version to fix build without cabal.project #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Aug 2, 2021

@jneira
Copy link
Member Author

jneira commented Aug 2, 2021

I have to test it locally, as ci here is using cabal.project

@jneira
Copy link
Member Author

jneira commented Aug 3, 2021

i tried this locally with ghc-8.8.4, removing the source-repository-package which make the build work and the build ended succesfully:

# cabal build lsp-types
..........
Completed    dependent-sum-0.7.1.0 (lib)
Starting     dependent-sum-template-0.1.0.3 (lib)
Building     kan-extensions-5.2.3 (lib)
Building     dependent-sum-template-0.1.0.3 (lib)
Installing   dependent-sum-template-0.1.0.3 (lib)
Completed    dependent-sum-template-0.1.0.3 (lib)
...
[51 of 51] Compiling Language.LSP.VFS ( src\Language\LSP\VFS.hs, D:\ws\haskell\haskell-lsp\dist-newstyle\build\x86_64-windows\ghc-8.8.4\lsp-types-1.3.0.0\build\Language\LSP\VFS.o )

# cat cabal.project
packages:
         ./lsp
         ./lsp-types/
         ./lsp-test/

package lsp
  flags: +demo

tests: True
benchmarks: True
test-show-details: direct
haddock-quickjump: True

allow-newer:
  lens:template-haskell,
  cryptohash-sha1:base,
  cryptohash-md5:base,
  hslogger:base,
  entropy:Cabal,

-- Required for ghc-9.0.1 support
source-repository-package
  type: git
  location: https://github.com/anka-213/th-extras
  tag: 57a97b4df128eb7b360e8ab9c5759392de8d1659
-- https://github.com/mokus0/th-extras/pull/8

//cc @bkomuves

@jneira
Copy link
Member Author

jneira commented Aug 3, 2021

We should try it with hls too before making a hackage revision

@jneira
Copy link
Member Author

jneira commented Aug 6, 2021

hls master cant be built with this pr nor the hackage version due to duplicate definitions for length, _start and maybe someone else
I am preparing a pr to make hls work on master/hackage released version, but using this did not fail at the solver phase, so I think we could merge it

@jneira jneira requested review from wz1000 and pepeiborra August 6, 2021 16:03
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jneira !

@jneira jneira merged commit f965241 into haskell:master Aug 6, 2021
@pepeiborra
Copy link
Collaborator

Could you make a Hackage revision too?

@pepeiborra
Copy link
Collaborator

hls master cant be built with this pr nor the hackage version due to duplicate definitions for length, _start and maybe someone else
I am preparing a pr to make hls work on master/hackage released version, but using this did not fail at the solver phase, so I think we could merge it

Are you sure HLS master doesn't build? What error do you get?

@jneira
Copy link
Member Author

jneira commented Aug 6, 2021

Oh, thanks for noting it, the work is already done with haskell/haskell-language-server#2059 😅

@jneira jneira mentioned this pull request Aug 6, 2021
@jneira jneira deleted the fix-hackage-ci branch August 7, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hackage ci fails to build lsp-types-1.3.0.0
2 participants