-
Notifications
You must be signed in to change notification settings - Fork 94
Add dependen-sum lower version to fix build without cabal.project #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jneira
commented
Aug 2, 2021
- F.e. the hackage ci build
- Fixes Hackage ci fails to build lsp-types-1.3.0.0 #349
I have to test it locally, as ci here is using cabal.project |
i tried this locally with ghc-8.8.4, removing the source-repository-package which make the build work and the build ended succesfully:
//cc @bkomuves |
We should try it with hls too before making a hackage revision |
hls master cant be built with this pr nor the hackage version due to duplicate definitions for length, _start and maybe someone else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @jneira !
Could you make a Hackage revision too? |
Are you sure HLS master doesn't build? What error do you get? |
Oh, thanks for noting it, the work is already done with haskell/haskell-language-server#2059 😅 |