Add with_module_name option to list_align #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@jaspervdj any chance of getting this merged in? We started using this as a default style at IOHK and it's causing some pain that it's not upstreamed! Thanks! |
|
@ruhatch LGTM, sorry for being unresponsive on this. Would it be possible to add a test as well though, so I don't break this in the future? |
|
@jaspervdj I added tests for this new feature, and @ruhatch had a look at them and he approves. Let me know whether this PR can be merged now. Thanks! |
|
Thank you, tests look very good! |
|
Thanks @jaspervdj . Any chances of having this in a release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.