Skip to content

Switch the default formatter to ormolu #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

Switch the default formatter to ormolu #258

merged 1 commit into from
Jul 31, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Jul 29, 2020

Since brittany isn't included in the static binaries due to licensing
restrictions
Fixes #255

@lukel97
Switch the default formatter to ormolu
f9f02fe 
Since brittany isn't included in the static binaries due to licensing
restrictions
Fixes haskell#255
@lukel97 lukel97 requested review from alanz, fendor and jneira July 29, 2020 16:26
@jneira
Copy link
Member

jneira commented Jul 29, 2020

I don't care much about, but why choose ormolu instead floskell or stylish-haskell which afaik are configurable...

@lukel97
Copy link
Collaborator Author

lukel97 commented Jul 29, 2020

I don't really use the formatters so I thought it would be good to open up a PR to and get a poll going for the new default formatter

@lukel97
Copy link
Collaborator Author

lukel97 commented Jul 29, 2020

Although with that said, it looks like the default formatter in hls itself is Ormolu:
https://github.com/haskell/haskell-language-server/blob/4fe0f7dfc1cac850a1a1a201fff41cdecc0fb7cf/src/Ide/Plugin/Config.hs#L66

@jneira
Copy link
Member

jneira commented Jul 29, 2020 •
edited
Loading

well, the config here should override the hardcoded one.
that said I've just read #255 so lgtm

@lukel97
Copy link
Collaborator Author

lukel97 commented Jul 29, 2020

I'll leave this sit for a day or so, just in case anyone has any strong opinions on this

fendor
fendor approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I dont care too much about it either.
It is still a political decision, maybe a poll in reddit/discourse/discord?

@lukel97
Copy link
Collaborator Author

lukel97 commented Jul 31, 2020

@fendor I was thinking about that as well, probably best to open this in the HLS repo though rather than bike shed about it here

@lukel97 lukel97 merged commit aeca671 into haskell:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@fendor fendor fendor approved these changes

@alanz alanz Awaiting requested review from alanz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No formatter found" (Brittany)
3 participants
@lukel97 @jneira @fendor