Skip to content

Add config options from last hls version #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2021
Merged

Add config options from last hls version #463

merged 6 commits into from
Sep 21, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 21, 2021 •
edited
Loading

  • Include the bump of webpack, as advised by dependant-bot alert and npm audit
  • haskell.plugin.refineImports.globalOn is not listed in haskell-language-server generate-default-config
  • i've not added haskell.checkParents as i am not sure if it is sensible to expose it to final users (//cc @pepeiborra)

@jneira jneira linked an issue Sep 21, 2021 that may be closed by this pull request
Add new config options from last hls-1.4.0 #459
Closed
@jneira jneira requested a review from berberman September 21, 2021 11:30
@berberman
Copy link
Collaborator

Should we remove (or hide, can we?) unsed options like haskell.formatOnImportOn or haskell.diagnosticsOnChange? For users, tweaking them does not make any sense, and I think they can be confusing.

berberman
berberman approved these changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneira jneira merged commit d93909c into haskell:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berberman berberman berberman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new config options from last hls-1.4.0
2 participants
@jneira @berberman