Skip to content

fix bash completion example docs on cli #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2019
Merged

fix bash completion example docs on cli #1832

merged 3 commits into from
Mar 28, 2019

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Mar 21, 2019

Description

Fix completion directory name (missing leading dot) for bash on Windows

Affected components

  • Docs

@simoneb simoneb requested a review from rikinsk-zz as a code owner March 21, 2019 10:36
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @simoneb, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 21, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit d10e3ba

https://deploy-preview-1832--hasura-docs.netlify.com

@shahidhk
Copy link
Member

Thanks for the PR @simoneb. The documentation is auto-generated from the CLI help. Can you also make the change here: https://github.com/hasura/graphql-engine/blob/master/cli/commands/completion.go#L29 ?

@shahidhk shahidhk added c/cli Related to CLI s/do-not-merge Do not merge this pull request to master labels Mar 27, 2019
@simoneb simoneb requested a review from shahidhk as a code owner March 27, 2019 23:55
@simoneb
Copy link
Contributor Author

simoneb commented Mar 27, 2019

@shahidhk done!

@hasura-bot
Copy link
Contributor

Review app for commit d10e3ba deployed to Heroku: https://hge-ci-pull-1832.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1832-d10e3ba

@shahidhk shahidhk changed the title Fix completion directory name (missing leading dot) for bash on Windows fix bash completion example docs on cli Mar 28, 2019
shahidhk
shahidhk approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit f6c11e5 into hasura:master Mar 28, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1832.herokuapp.com is deleted

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Mar 28, 2019
@shahidhk
Copy link
Member

Thanks a ton @simoneb 👍

@slimlime slimlime mentioned this pull request Jul 22, 2020
Open
hasura-bot pushed a commit that referenced this pull request Apr 9, 2025
@danieljharvey @hasura-bot
Improved missing boolean expression field error (#1832)
0003fff 
<!-- The PR description should answer 2 important questions: -->

### What

Got tripped up by this error when writing test metadata, because it says
there's no field in the object type, but it really means "there's no
field in the `BooleanExpressionType`", so fixed it.

V3_GIT_ORIGIN_REV_ID: 83c220451f914d816e3239835d5cc6dc07d44333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@rikinsk-zz rikinsk-zz Awaiting requested review from rikinsk-zz

Assignees
No one assigned
Labels
c/cli Related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simoneb @hasura-bot @CLAassistant @shahidhk