Auto-generated insert procedures v1 #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 16, 2024 12:35
SamirTalwar
reviewed
Jan 18, 2024
Comment on lines
113
to
116
| CASE WHEN attgenerated_exists | ||
| THEN CASE WHEN attgenerated::text = 's' THEN 'isGenerated' ELSE 'notGenerated' END | ||
| ELSE 'notGenerated' | ||
| END as is_generated |
There was a problem hiding this comment.
Seems like a strange way to implement booleans. Why not true and false?
There was a problem hiding this comment.
Just liked being explicit, wouldn't mind changing it to bool if you want me to.
There was a problem hiding this comment.
Makes me uneasy because there's the potential of many values here, rather than the two we care about.
There was a problem hiding this comment.
I've changed this so instead of returning isGenerated, it will return stored, so that if and when postgres adds additional values to this, it will be strictly additive.
crates/query-engine/translation/src/translation/mutation/insert.rs
Outdated
Show resolved
Hide resolved
soupi
force-pushed
the
gil/gen-insert-v1
branch
from
87308c9 to
cc8b272
Compare
soupi
commented
Jan 19, 2024
There was a problem hiding this comment.
a v1 config snapshot! Generated because we added a new table (custom.dog).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We'd like to auto-generate insert procedures for tables.
How
Soon, tl;dr:
todo: add engine metadata for
v1_insert_custom_dog.