Add support for introspecting domain types #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plcplc
force-pushed
the
plc/issues/PG-61
branch
from
56df009 to
631d96d
Compare
static/schema.json
Outdated
| @@ -745,7 +745,41 @@ | |||
| } | |||
| } | |||
| }, | |||
| "Native_query_sql": { | |||
| "NativeQuerySql": { | |||
There was a problem hiding this comment.
This feels like it's related to @soupi 's recent .sql files change for native queries rather than domain types?
danieljharvey
approved these changes
Mar 25, 2024
SamirTalwar
reviewed
Mar 26, 2024
| 'c', --for composite type | ||
| -- 'd' for domain (a predicate-restricted version of a type) | ||
| 'c', -- for composite type | ||
| -- 'd', for domain (a predicate-restricted version of a type) |
| @@ -0,0 +1,5 @@ | |||
| -- This file is used to test the support of domain types | |||
|
|
|||
| CREATE DOMAIN even_number int4 CHECK (VALUE % 2 = 0); | |||
There was a problem hiding this comment.
I did not know you could do this in SQL and now I do.
I'm not sure if this is a blessing or a curse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for introspecting domain types.
How
Prior to this PR domain types were already recognised as scalar types. However, the ability to view a domain type transparently as its base type was not, so you couldn't do anything with values of domain type.
This PR adds cases to the set of implicit casts for domain types in the introspection query, which enables support for comparison operators.