Support enum types #387
Merged
Support enum types #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "message": "Unprocessable content", | ||
| "details": { | ||
| "detail": "error returned from database: invalid input value for enum card_suit: \"horses\"" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR improves introspection support for enum types.
Comparison operators and aggregation functions on enum types are implicitly defined in PostgreSQL and thus were not detected prior to this PR.
How
We simply collect which enum types are defined and make up the conventional comparison operators and the min/max aggregation functions for all enum types.
We test that we can select and aggregate enum types, and that we can insert enum values which PostgreSQL validates.
We also collect the enum value labels, which we will be using once ndc-spec v0.1.1 is released.