Skip to content

Warn when the configuration is deprecated #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

soupi
Copy link
Contributor

@soupi soupi commented Jul 16, 2024

What

We'd like to mark configuration version 3 and 4 as deprecated.
We'll mention this in the docs, and also trace a warning when starting the connector with an older configuration version.

{"timestamp":"2024-07-16T13:02:04.857565Z","level":"WARN","fields":{"message":"Warning: ndc-postgres configuration version '3' is deprecated.\nConsider upgrading to the latest version:\nhttps://hasura.io/docs/3.0/connectors/postgresql/configuration-reference/#upgrading-the-configuration-format-version"},"target":"ndc_postgres::connector"}

How

trace a warning pointing at how to upgrade the configuration.

@soupi soupi enabled auto-merge July 16, 2024 13:25
@soupi soupi disabled auto-merge July 16, 2024 13:25
@soupi soupi added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit effd73c Jul 17, 2024
31 checks passed
@soupi soupi deleted the gil/deprecation-warning branch July 17, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants