Array elements are always nullable #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupi
reviewed
Aug 13, 2024
static/institution.sql
Outdated
| @@ -69,12 +69,11 @@ ROW( | |||
| 3421 -- NULL | |||
There was a problem hiding this comment.
Could you also replace this?
Suggested change
| 3421 -- NULL | |
| NULL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
PR #565 fixed field nullability of composite type fields, but neglected to treat the similar issue that exists for arrays.
In Postgres, any array type (e.g.
int4[],text[], etc.) may contain elements which are null. The type system does not support declaring arrays with non-null elements.This PR fixes that issue.
How
Whenever we have to translate an ndc-postgres array type to an ndc-spec array type in the schema generation we annotate the element type as being nullable.