Skip to content

Remove deprecated items. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

OleksiiZubko
Copy link
Collaborator

This CR removes all deprecated items with the
deprecated time more than 6 months.

Resolves: OLPEDGE-2351

Signed-off-by: Oleksii Zubko [email protected]

@OleksiiZubko OleksiiZubko force-pushed the task/olpedge-2351-remove-deprecates branch 2 times, most recently from 11f89e4 to 858c1d7 Compare October 17, 2020 09:21
@codecov-io
Copy link

Codecov Report

Merging #385 into master will decrease coverage by 0.2387%.
The diff coverage is 83.3334%.

Impacted file tree graph

@@               Coverage Diff                @@
##             master       #385        +/-   ##
================================================
- Coverage   88.0983%   87.8596%   -0.2386%     
================================================
  Files            72         72                
  Lines          2403       2364        -39     
  Branches        264        263         -1     
================================================
- Hits           2117       2077        -40     
- Misses          161        162         +1     
  Partials        125        125                
Impacted Files Coverage Δ
@here/olp-sdk-dataservice-api/lib/lookup-api.ts 59.2593% <ø> (-13.2407%) ⬇️
@here/olp-sdk-dataservice-api/lib/stream-api.ts 90.1409% <ø> (+0.8552%) ⬆️
...olp-sdk-dataservice-read/lib/client/DataRequest.ts 89.4737% <ø> (-1.4354%) ⬇️
...ervice-read/lib/client/QuadKeyPartitionsRequest.ts 100.0000% <ø> (ø)
...k-dataservice-read/lib/client/StatisticsRequest.ts 100.0000% <ø> (ø)
...aservice-read/lib/cache/MetadataCacheRepository.ts 80.0000% <50.0000%> (-3.3333%) ⬇️
...dk-dataservice-read/lib/client/IndexLayerClient.ts 91.3044% <100.0000%> (-1.7990%) ⬇️
...olp-sdk-dataservice-read/lib/client/QueryClient.ts 73.2143% <100.0000%> (-1.3311%) ⬇️
...dataservice-read/lib/client/VolatileLayerClient.ts 81.9445% <100.0000%> (-1.3888%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77929cc...858c1d7. Read the comment docs.

@OleksiiZubko OleksiiZubko requested a review from andescu October 17, 2020 09:30
@OleksiiZubko OleksiiZubko force-pushed the task/olpedge-2351-remove-deprecates branch from 858c1d7 to 9cd8da1 Compare October 20, 2020 05:53
@OleksiiZubko OleksiiZubko requested a review from andescu October 20, 2020 05:55
@OleksiiZubko OleksiiZubko force-pushed the task/olpedge-2351-remove-deprecates branch from 9cd8da1 to e5eaad3 Compare October 20, 2020 14:43
This CR removes all deprecated items with the
deprecated time more than 6 months.

Resolves: OLPEDGE-2351

Signed-off-by: Oleksii Zubko <[email protected]>
@OleksiiZubko OleksiiZubko merged commit 002e9e4 into master Oct 21, 2020
@OleksiiZubko OleksiiZubko deleted the task/olpedge-2351-remove-deprecates branch October 21, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants