Skip to content

Remove deprecated code. #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Remove deprecated code. #425

merged 1 commit into from
Feb 9, 2021

Conversation

OleksiiZubko
Copy link
Collaborator

Removing deprecated code which we've moved
to the core component 6months ago.

Adapted tests.

Resolves: OLPEDGE-2466

Signed-off-by: Oleksii Zubko [email protected]

@OleksiiZubko OleksiiZubko force-pushed the task/olpedge-2466 branch 7 times, most recently from a87dd8b to 2f9863a Compare February 8, 2021 00:17
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #425 (d357ae0) into master (1b4d064) will decrease coverage by 0.2238%.
The diff coverage is 71.4286%.

Impacted file tree graph

@@               Coverage Diff                @@
##             master       #425        +/-   ##
================================================
- Coverage   88.0296%   87.8058%   -0.2237%     
================================================
  Files            73         75         +2     
  Lines          2573       2698       +125     
  Branches        286        308        +22     
================================================
+ Hits           2265       2369       +104     
- Misses          167        180        +13     
- Partials        141        149         +8     
Impacted Files Coverage Δ
...ervice-read/lib/client/QuadKeyPartitionsRequest.ts 100.0000% <ø> (ø)
...olp-sdk-dataservice-read/lib/client/QueryClient.ts 73.2143% <ø> (ø)
...olp-sdk-dataservice-read/lib/utils/QuadKeyUtils.ts 100.0000% <ø> (+6.3830%) ⬆️
...here/olp-sdk-dataservice-read/lib/utils/getTile.ts 12.9630% <33.3334%> (+2.0255%) ⬆️
...olp-sdk-dataservice-read/lib/client/DataRequest.ts 87.5000% <100.0000%> (-1.9736%) ⬇️
...ataservice-read/lib/client/QuadTreeIndexRequest.ts 95.6522% <100.0000%> (ø)
...olp-sdk-dataservice-read/lib/client/TileRequest.ts 100.0000% <100.0000%> (+26.6667%) ⬆️
...dataservice-read/lib/client/VolatileLayerClient.ts 83.6066% <100.0000%> (+1.6622%) ⬆️
@here/olp-sdk-core/lib/client/OlpClientSettings.ts 100.0000% <0.0000%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4d064...5b705a5. Read the comment docs.

andescu
andescu previously approved these changes Feb 9, 2021
Removing deprecated code which we've moved
to the core component 6months ago.

Adapted tests.

Resolves: OLPEDGE-2466

Signed-off-by: Oleksii Zubko <[email protected]>
@OleksiiZubko OleksiiZubko merged commit 5f15e93 into master Feb 9, 2021
@OleksiiZubko OleksiiZubko deleted the task/olpedge-2466 branch February 9, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants