Minor change in poll method. #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiiZubko
force-pushed
the
OLPEDGE-2663-fix-stream-layer
branch
from
fcff50f to
c7f07ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
================================================
+ Coverage 88.9567% 89.5700% +0.6133%
================================================
Files 82 82
Lines 2952 2953 +1
Branches 329 330 +1
================================================
+ Hits 2626 2645 +19
+ Misses 178 153 -25
- Partials 148 155 +7
Continue to review full report at Codecov.
|
OleksiiZubko
force-pushed
the
OLPEDGE-2663-fix-stream-layer
branch
4 times, most recently
from
96e9cbc to
2a36532
Compare
andescu
reviewed
Dec 14, 2021
OleksiiZubko
force-pushed
the
OLPEDGE-2663-fix-stream-layer
branch
from
2a36532 to
f752c63
Compare
andescu
previously approved these changes
Dec 21, 2021
The issue is about sending POST requests for committing ofsets in `poll` method even if no messages in `poll` response. The backend sends back an error about invalid parameters of committing offsets requests in this case. This fix checks the count of messages in the poll response and sends committing requests only if messages are retrieved. Relates-To: OLPEDGE-2663 Signed-off-by: Oleksii Zubko <[email protected]>
OleksiiZubko
force-pushed
the
OLPEDGE-2663-fix-stream-layer
branch
from
f752c63 to
bdb2469
Compare
ystefinko
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is about sending POST requests for committing ofsets in
pollmethodeven if no messages in
pollresponse.The backend sends back an error about invalid parameters of committing offsets
requests in this case.
This fix checks the count of messages in the poll
response and sends committing requests only if messages are retrieved.
Relates-To: OLPEDGE-2663