HHH-19392 UserType implementation may not work due to recent changes #10091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….UserType and org.hibernate.metamodel.mapping.BasicValuedMapping
Revert "fix code in CustomType that didn't make sense" This reverts commit 3f8ac48.
cigaly
force-pushed
the
HHH-19392-Previous_code_was_making_sense
branch
from
3c0fbb2 to
b0458e9
Compare
gavinking
reviewed
Apr 28, 2025
...org/hibernate/orm/test/type/contributor/usertype/BasicValuedMappingUserTypePropertyTest.java
Show resolved
Hide resolved
gavinking
reviewed
Apr 28, 2025
gavinking
reviewed
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19392
Change made by commit
3f8ac48df28bb7c28561ba92e4df1fcb8ae568cbis now causing problem with (some)org.hibernate.usertype.UserTypeimplementations.Suggested changes is to revert offending commit since it is not causing any of existing tests to fail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.