Skip to content

HHH-5838 - Proxool connection pool should only close pools it opened #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jan 14, 2011

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jan 13, 2011

for branch 3.6 only, another pull request follows for master

@emmanuelbernard
Copy link
Member

I've commented on the commit

@Sanne
Copy link
Member Author

Sanne commented Jan 13, 2011

added tests and included your suggestion.
I'd mention that it introduces an extremely unlikely race condition, still I agree it's better as it's more unlikely to break anything for whoever was not affected by this issue (likely the rest of the universe as nobody reported this before).

Now to see if I can add the dependency to gradle..

@emmanuelbernard
Copy link
Member

Sanne do you mean I can work on applying this pull request?

@Sanne
Copy link
Member Author

Sanne commented Jan 14, 2011

I consider it finished, something looking fishy?

Naros pushed a commit to Naros/hibernate-orm that referenced this pull request Apr 29, 2016
…ularDependencyCascadeTest

Fix NonNullableCircularDependencyCascadeTest
SweetWuXiaoMei pushed a commit to SweetWuXiaoMei/hibernate-orm that referenced this pull request Apr 29, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants