Skip to content

Add check mark in front of the selected driver #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2023
Merged

Add check mark in front of the selected driver #1566

merged 2 commits into from
Apr 6, 2023

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Apr 6, 2023 •
edited
Loading

Fix #1565

Log example:

INFO DefaultSqlClientPoolConfiguration [vert.x-worker-thread-0] HR000025: Connection pool size: 5
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.pgclient.spi.PgDriver] 
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.mysqlclient.spi.MySQLDriver] ✓

@DavideD
Copy link
Member Author

DavideD commented Apr 6, 2023

@gavinking, I've logged all the detected drivers like this:

INFO DefaultSqlClientPoolConfiguration [vert.x-worker-thread-0] HR000025: Connection pool size: 5
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.pgclient.spi.PgDriver] ✓
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.mysqlclient.spi.MySQLDriver] 
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.db2client.spi.DB2Driver] 
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.mssqlclient.spi.MSSQLDriver] 
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver [io.vertx.oracleclient.spi.OracleDriver] 
WARN ReactiveGenerationTarget [vert.x-eventloop-thread-0] HR000021: DDL command failed [io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:5432]

Is this good enough to show which driver we are going to use, or do we have to highlight it more?

@DavideD
Copy link
Member Author

DavideD commented Apr 6, 2023 •
edited
Loading

I guess most developers will only have one or two drivers on the classpath, so this approach should be fine

@gavinking
Copy link
Member

Looks good to me.

@DavideD
Copy link
Member Author

DavideD commented Apr 6, 2023

Maybe this is more readable:

INFO DefaultSqlClientPoolConfiguration [vert.x-worker-thread-0] HR000025: Connection pool size: 5
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver ✓[io.vertx.pgclient.spi.PgDriver]
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver  [io.vertx.mysqlclient.spi.MySQLDriver]
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver  [io.vertx.db2client.spi.DB2Driver]
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver  [io.vertx.mssqlclient.spi.MSSQLDriver]
INFO DefaultSqlClientPool [vert.x-worker-thread-0] HR000013: Detected driver  [io.vertx.oracleclient.spi.OracleDriver]

@DavideD DavideD merged commit be7422d into hibernate:main Apr 6, 2023
@DavideD DavideD deleted the 1565 branch April 6, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log a check mark in front of the selected driver
2 participants
@DavideD @gavinking