Skip to content

Cleanups and sync with 6 #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Cleanups and sync with 6 #1589

merged 5 commits into from
Apr 13, 2023

Conversation

gavinking
Copy link
Member

No description provided.

MutationExecutor executor = mutationExecutorService
.createExecutor( this::getInsertBatchKey, operationGroup, session );
return (ReactiveMutationExecutor) executor;
return (ReactiveMutationExecutor) mutationExecutorService.createExecutor( this::getInsertBatchKey, operationGroup, session );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [InsertCoordinator.getInsertBatchKey](1) should be avoided because it has been deprecated.
return reactiveInitializeLazyProperty( field.getName(), entity, session );
}

default <E, T> CompletionStage<T> reactiveInitializeLazyProperty(

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ReactiveEntityPersister.reactiveInitializeLazyProperty](1); it is advisable to add an Override annotation.
String fieldName = field.getName();
Object result = initializeLazyProperty( fieldName, entity, session );
if (result instanceof CompletionStage) {
default <E, T> CompletionStage<T> reactiveInitializeLazyProperty(

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ReactiveEntityPersister.reactiveInitializeLazyProperty](1); it is advisable to add an Override annotation.
// Since the loadedState in the EntityEntry is a flat domain type array
// We first have to extract the component object and then ask the component type
// recursively to give us the value of the sub-property of that object
final Type propertyType = entry.getPersister().getPropertyType( componentPath.get(0) );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [EntityPersister.getPropertyType](1) should be avoided because it has been deprecated.
@gavinking gavinking merged commit bba51d7 into hibernate:main Apr 13, 2023
@gavinking gavinking deleted the cleanups branch June 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant